Unity 5.6/2017 UNet - Stopping client via NetworkManager timeouts connection instead of disconnect

I'm using custom network manager and trying to disconnect client from the server when user decides to leave the server like so:

Code (CSharp):

1.  
2. void Leave(){
3. ...
4.            if (NetworkServer.active && NetworkClient.active) {
5.                 CustomNetworkManager.singleton.StopHost();
6.             } else if (!NetworkServer.active && NetworkClient.active) {
7.                 CustomNetworkManager.singleton.StopClient();
8.             } else {
9.                 DisplayOfflinePanel();
10.             }
11. ...
12. }
13.  

But it seems to be causing timeout for the connection on the server, instead of a proper disconnect:

Is this intended, or it's a bug?

 

I can confirm this has started happening with 5.6, with both the low-level API and the high-level API. When using the low-level API the output is a bit different:

reactor filed to acomplish request with code {1234}, bytesReceived {0}
reactor filed to acomplish request with code {1234}, bytesReceived {0}
reactor filed to acomplish request with code {1234}, bytesReceived {0}
Log: connection {1} has been disconnected by timeout; address {127.0.0.1:63855}

I pinged @aabramychev about this a couple of days ago and he told me he is aware of the issue and that it should be fixed in an upcoming patch release. Which is, of course, very much appreciated!

 

Thank you for confimation, that's good to know. Will be looking forward next patch release.

 

Same behavior with p2. Will be waiting for p3.

 

This is still an issue with p3.

T_T

 

Bump?

 

I don't see any fixes related to networking in the release notes for p1, p2, or p3.

 

Any news? It is critical

 

Hi aabramychev! My current issue is related to this (LLAPI)!

In my server logs I get this for example...
.................
Log: connection {44} has been disconnected by timeout; address {::ffff:213.92.138.185:65316}
Attempt to send to not connected connection {44}

(Filename: Line: 359)

Sending Error: 2
.................................


I assume the Timeout happened when I called NetworkTransport.Send()? (Send() and ReceiveFromHost() are the only 2 places where a timeout can occur, right?)

But I need to get the connectionID to cleanup and destroy the Player object tied to that connection. But this timeout/Send() responds with Sending Error 2 (invalid connection) rather than Sending Error 4 (Timeout)....

So it looks like my server cannot find then destroy this invalid connectionID (-> Player object) and gets stuck trying to send to it until all queues are full and the server crashes.

Are my assumptions correct? How would I handle this timeout on Send().. when apparently I can't get the exact connection that's timed out?

EDIT: My disconnect / timeout handling code looks like this... But doesn't seem to work with an invalid connection returned.

if (!NetworkTransport.Send(
host,
connection,
channel,
buffer,
writer.Position,
out rError) || rError != (byte)NetworkError.Ok)
{
Debug.Log ("Sending Error: " + rError);
disconnectQueue.Enqueue (connection);
}

EDIT2: Looking at my code again, I think the error is maybe another player connecting and getting the same connection ID before the disconnectQueue is flushed and cleaned up. I will try this fix.

Please let me know
Benz

 

Ah thank you! This finally explains the hidden crash bug and NoResources errors on my server! Will fix now.

 

Ok, so there's no fix to this (Timeout instead of disconnect), right?
I've tried coroutine wait approach with no luck. In that frame after disconnect but before stop there's actually messages that communicate between client and server, which results in even more error messages popping up.

Any other ideas? Use LLAPI instead? I would REALLY appreciate an example of how it should be done.

Why it matters? Because it adds additional unrelated to debugging information to the log, which is not usefull when there's multiple servers running on the same machine.

 

That would take ages to do. I just want to have a proper player disconnect without receiving timeout message. In fact it doesn't even matter for our game if it is a timeout or an actual player-driven disconnect. It's the message that is the problem: "Failed to send buffer + timeout" error that pops every time when player disconnects.

I bet there's a different way to implement disconnect than using Coroutines (since that didn't worked at all). I don't know, maybe a message pass between server and client?

In what order and what should be called?

Edit:
This is what I tried so far - I'm sending message from client to the server asking for a disconnect, server does that and client is either disconnects on it's own, or does a proper disconnect procedure after a while anyway.

Code (CSharp):

1.         private Coroutine _disconnectCoroutine;
2.         private readonly WaitForSeconds _clientShutdownDelay = new WaitForSeconds(0.5f);
3.  
4.         public override void OnServerReady(NetworkConnection conn) {
5.             NetworkServer.SetClientReady(conn);
6.  
7.             RegisterServerHandlers();
8.         }
9.  
10.         private void RegisterServerHandlers() {
11.             NetworkServer.RegisterHandler((short) CustomOpCodes.UnetDisconnect, DisconnectClient);
12.         }
13.  
14.         /// <summary>
15.         /// Disconnects client connection from the server
16.         /// </summary>
17.         /// <param name="message">Empty message</param>
18.         private static void DisconnectClient(NetworkMessage message) {
19.             NetworkConnection networkConnection = message.conn;
20.             networkConnection.Disconnect();
21.             networkConnection.Dispose();
22.         }
23.  
24.         public void StopClient(NetworkConnection clientConnection) {
25.             clientConnection.Send((short) CustomOpCodes.UnetDisconnect, new EmptyMessage());
26.  
27.             if (_disconnectCoroutine != null) {
28.                 StopCoroutine(_disconnectCoroutine);
29.             }
30.  
31.             _disconnectCoroutine = StartCoroutine(StopClientAfterDelay());
32.         }
33.  
34.         private IEnumerator StopClientAfterDelay() {
35.             yield return _clientShutdownDelay;
36.  
37.             if (NetworkClient.active) {
38.                 OnStopClient();
39.                 if (LogFilter.logDebug)
40.                     Debug.Log("NetworkManager StopClient");
41.                 isNetworkActive = false;
42.                 if (client != null) {
43.                     client.Disconnect();
44.                     client.Shutdown();
45.                     client = null;
46.                 }
47.             }
48.  
49.             yield return null;
50.         }

Problem is - it still adds message to the internal buffer, spitting out errors. I've tried increasing\decreasing delay, WaitForEndOfFrame, still the same. Fun fact - proper disconnect occurs, if not counting that client is piling up messages before disposing. Critical backdraw - it utterly HANGS server. I don't know why.

I guess I'll need to dig deeper into Unet NetworkServer/NetworkClient to implement everything properly.

 

Complicated or not, the NetworkManager should supply a proper Leave/Quit/Something method. Having everyone make it themselves lowers the value of the NetworkManager as an API. Is there any arguments against adding it to the NetworkManager, except time required?

Also, the error message is pretty bad. "ServerDisconnected due to error: Timeout" sounds like the server disconnected and not the client. I suggest it should say "ServerDisconnect due to error: Timeout" if changing error messages is not considered a serious backwards-incompatible change.