Migration to Unity 5.6.1: APIUpdater

Hi,

I'm migrating from Unity 5.5.3 to 5.6.1. Building for Android (il2cpp) fails with following errors:

Code (csharp):

1. Exception: C:\Program Files\Unity-5.6.1p\Editor\Data\Tools/UnusedByteCodeStripper2/UnusedBytecodeStripper2.exe did not run properly!
2. UnityEditorInternal.Runner.RunManagedProgram (System.String exe, System.String args, System.String workingDirectory, UnityEditor.Scripting.Compilers.CompilerOutputParserBase parser, System.Action`1 setupStartInfo) (at C:/buildslave/unity/build/Editor/Mono/BuildPipeline/BuildUtils.cs:98)
3. UnityEditorInternal.AssemblyStripper.RunAssemblyLinker (IEnumerable`1 args, System.String& out, System.String& err, System.String linkerPath, System.String workingDirectory) (at C:/buildslave/unity/build/Editor/Mono/BuildPipeline/AssemblyStripper.cs:102)
4. UnityEditorInternal.AssemblyStripper.StripAssembliesTo (System.String[] assemblies, System.String[] searchDirs, System.String outputFolder, System.String workingDirectory, System.String& output, System.String& error, System.String linkerPath, IIl2CppPlatformProvider platformProvider, IEnumerable`1 additionalBlacklist) (at C:/buildslave/unity/build/Editor/Mono/BuildPipeline/AssemblyStripper.cs:95)
5. ...
6. UnityEditor.PostprocessBuildPlayer.Postprocess (BuildTargetGroup targetGroup, BuildTarget target, System.String installPath, System.String companyName, System.String productName, Int32 width, Int32 height, System.String downloadWebplayerUrl, System.String manualDownloadWebplayerUrl, BuildOptions options, UnityEditor.RuntimeClassRegistry usedClassRegistry, UnityEditor.BuildReporting.BuildReport report) (at C:/buildslave/unity/build/Editor/Mono/BuildPipeline/PostprocessBuildPlayer.cs:186)
7. UnityEditor.HostView:OnGUI()

and

Code (csharp):

1. APIUpdater encountered some issues and was not able to finish.
2.     System.InvalidOperationException: Sequence contains more than one element
3.       at System.Linq.Enumerable.SingleOrDefault[TSource] (System.Collections.Generic.IEnumerable`1[T] source) [0x000a3] in <776c86d7978548379a28dce0f5e4ccbb>:0
4.       at CSharpUpdater.Steps.MemberReferenceReplacerBase`1[T].CommentedOutClashingNamedExpression (Microsoft.CodeAnalysis.CSharp.Syntax.SimpleNameSyntax namedExpression, System.String replacement) [0x0001a] in <b7cb13f7ec2246c886e193d293370e2c>:0
5.       ...
6.       at ScriptUpdater.Program.UpdateLanguage (APIUpdater.Framework.Core.IScriptUpdater updater, APIUpdater.Framework.Configuration.CompilerResponseFile responseFile, System.String unityDataPath, System.String outputPath) [0x000b3] in <a7ef413534cd40558c8276304ebb3af4>:0
7.       at ScriptUpdater.Program.Main (System.String[] args) [0x000d5] in <a7ef413534cd40558c8276304ebb3af4>:0

I've already filed tickets 903332 and 902973 some time ago.

Could you please check call to `SingleOrDefault()` somewhere in `CommentedOutClashingNamedExpression()` or neighbourhood?

Thanks!

@JoshPeterson

 

@JoshPeterson ...Or just open sources of “API Updater” so I could fix it by myself and pull-request.

 

Yes, I could try modified version with enhanced logging.

 

According to dotPeek, the problem is in this method:

Code (csharp):

1.     private bool CommentedOutClashingNamedExpression(SimpleNameSyntax namedExpression, string replacement)
2.     {
3.       if (namedExpression == null)
4.         return false;
5.       InitializerExpressionSyntax expressionSyntax = namedExpression.Ancestors(true).OfType<InitializerExpressionSyntax>().SingleOrDefault<InitializerExpressionSyntax>();
6.       if (expressionSyntax == null)
7.         return false;
8.       SourceRange objectInitializer = this.RangeToCommentOutDueToClashingNameInObjectInitializer(expressionSyntax.Expressions.OfType<AssignmentExpressionSyntax>(), namedExpression, replacement);
9.       if (!objectInitializer.IsValid)
10.         return false;
11.       this.UpdateCollector.Insert(objectInitializer.Start, "/*", (object) null, (object) null);
12.       this.UpdateCollector.Insert(objectInitializer.End, "*/", (object) null, (object) null);
13.       this.UpdaterContext.Listener.Log(APIUpdater.Framework.Log.LogLevel.Warning, "warning: Expression '{0}' in '{1}' has been commented out due to member '{2}' being replaced with '{3}'.", (object) namedExpression, (object) namedExpression.GetLocation().GetMappedLineSpan().Path, (object) namedExpression.Identifier, (object) replacement);
14.       return true;
15.     }

Looks like wrong assumption on amount of `InitializerExpressionSyntax` nodes. Maybe it's worth trying to replace `SingleOrDefault<InitializerExpressionSyntax>()` call with iteration over all nodes?

Code (csharp):

1. foreach (InitializerExpressionSyntax expressionSyntax in namedExpression.Ancestors(true).OfType<InitializerExpressionSyntax>()) { ... }

 

Thanks, I've received zip-archive! I will try it tomorrow at work (located in UTC+3 time zone).