Cinematic Image Effects (Pre Release) package

I've often seen something like that with additive particles making areas of the screen too bright in HDR. I suspect this is a general Unity issue - one which I personally consider a bug, but it seems to be happening so consistently that I almost feel like this is by design. I think the effect starts somewhere around a brightness level of 2. I've even modified a particle shader to clamp brightness beyond a certain value to avoid colors getting darker again. I've seen the effect in published games too, like in the fire in 7 Days to Die (not sure if it is still there, didn't play that in a while). To me it's quite annoying. I also can't think of a reason why this would be considered a "feature" instead of a "bug". But maybe I'm just not understanding its purpose or logical reason. Can you give an explanation? Thanks for looking into it!

 

Depth of Field: I was excited about the Explicit mode, as I have a need to manually place the Near plane and Far plane. However, this mode leaves me with only the Focus Range slider to soften the transition between blurred and focused areas, and it doesn't make that transition very smooth at all. (Compare this with the F-Stops control in Basic and Advanced modes that make blur/focus transitions super smooth.) Can you allow the F-Stops controls to remain in Explicit mode, or make the Focus Range control way, way more effective?

 

Having values over 1 in the internal hdr representation of the image is totally fine - wanted actually, for bloom etc.. I just don't understand why those get visually represented as cyan rather than 255/255/255 white on my screen. My understanding is that fullwhite is the brightest color a screen can show, why does it get darker visually on my screen, when the hdr color gets too bright. That makes no sense to me. Can you explain why this happens?

 

You'd need some form of clamp for HDR if you want to go nuts with additive on additive cos the final pixel will just keep getting added to? Cyan is cos the number wraps after a sufficiently large range (as I understand it).

I would rather evade it than have a final blit checking each pixel can't be brighter than white.

 

But why cyan? Or rather, why does it stay cyan and doesn't look like some rainbow colored glitch when I further increase the brightness? I can't make sense of this in a mathematical sense. If it was some kind of overflow like a binary 11111111 going to 00000000 when I add another 1, that would keep changing its value as long as I keep adding the 1, it wouldn't stabilize on a number that corresponds to a very specific color. I just don't get what's going on here.
By the way I only could reproduce that with a particle shader. The PBR standard shader with an emissive material turned to 99 brightness didn't cause the same issue, which confuses me even further. I feel like I'm not understanding something :-/.

 

Has anyone tried the playdead version of the TAA? (I can't find a thread dedicated to it)
I have some performance issues with the Velocity buffer. It seems that if you have like 10 objects moving on your scene (only meshes, not skinned) sending the velocity buffer will take 4ms. That's ridiculously insane, to say the least. The post effect itself is very fast (0.04ms on my profiler) though, that's not an issue.

Please tell me if you encountered this performance issues as well,
thanks !

 

They already put a note in the readme that tagging skinned mesh into velocity buffer are expensive. Also they have source license so the actuall TAA they used are C++ integrated directly into internal rendering. The version in github repo are ported to C# afaik

 

Unity is spamming me with this warning message. I can't use Anti-Aliasing or Tonemapping. I am using unity 5.3.4p1. I have the latest upgrade to the cinematic image effects package.

If someone can help me, I would be happy. Thanks!

 

Fixed this problem. Delete all image effects and other effects then reimported them all. Works perfectly now

 

I rate these effects a 6.8/10. They are good. But there are a lot of bugs (Beta version). But i would recommend that you try these effects if you haven't already!

 

Hmm... maybe its just me - but I am loving these new FX and am having a blast with them!

The one major comment so far is that there seems to be something very off with the SpeedTree shaders. Light coming through the leaves is completely off. Check the second image.





Generated with Unity 5.3.4p1, and the latest asset store version of Cinematic FX.

 

Do you guys have flickering ocurring when using SMAA? I just had to go back to FXAA because of it. It's mostly noticeable on planes and angles parallel to the camera like stairs and boxes.

 

Anti-aliasing for one has a major flickering problem where it flickers along edges of objects in the scene, and sometimes renders my camera black. Hopefully you guys fix this soon

There was an issue with tonemapping saturation, when you scale it up or down it wouldn't effect the saturation at all, but it did create a shell around objects which made it look as if you could see atlas texture padding. I restarted unity and it went away. But i'm not sure if i needed to reboot unity or if this was indeed a bug. If it occurs again i will surely upload screenshots.

Ambient Occlusion makes the camera render objects that are behind walls or other objects when those objects are not using the standard shader.
Ambient Occlusion: On

Ambient Occlusion: Off (Legacy Shader)

 

Also, in the scene I posted with the car, when the camera is behind the car or in dark areas, it does not lighten the view at all. Eye adaptation also does not work with any other image effects like bloom. Not sure if this is a bug or if this was how it was intended to be. When i get close to very emissive objects, it does not adjust to bring down the exposure.

 

I think I've found the issue with my shader. I was using "Blend OneMinusDstColor One" where I should have used "Blend One One". Brightness values in the hundreds now work as expected. In the old blend mode I was hitting the color errors at a brigthness of ~2-3 already.

 

Honestly from what I can see it's pretty much the driver's fault. Your scenes don't look remotely physically accurate so you will get all kinds of values in your gbuffers so pretty much everything except LDR post would look bad for you.

Not being offensive, just pointing out should you be able to correct your lighting, ensure it's HDR, linear and you're using sane values and its STILL not behaving then I guess it is a bug, but filing a bug report should see it fixed (screenshots would be hard for unity to figure out where the problem is).

 

I am using the tessellation shader from standard assets. I am also using Deferred Lighting.

 

Go through your materials and enable Debug in the inspector, then check and see if the tags are properly set up. I once had an issue where the wrong RenderType was serialized for a material (it didn't match what I had defined in my shader, so the object was rendered as if it was transparent even though the shader defined it as Opaque - and this had very similar results as you encountered when AO was enabled)

 

Is it just me or the Ambient Only for AO are broken? or is it not working from the beginning?
Hah. . . surprisingly i can make the SSR to work with semi transparent object. But i have to use dithered alpha

 

Ambient only AO means that the AO will only appear where it is not directly touched by light. "Dithered alpha" should work as it is cutout queue (just after opaque, before transparent - ie it's not alpha)

 

I know, it was working before. But after last pull it doesn't work anymore.

yeah that's what i mean

 

Yes i'am, so i guess that what causing it then. i'll wait for the next beta

That's the idea, i've been combine that with FXAA and it looks great, can't wait for your solution.
Also a bonus from this technique is shadow cast/receiver
The only drawback is sometimes it feel noisy

 

If you are talking about the screenspace reflections I recommend to take a look at how the one in UE4 looks (or even the source if that is open) because it seems to have a heavy temporal component that gives it a great reflection quality after the image stabilizes. I'm looking forward to see what you'll come up with. I'm sure it's going to rock!

 

Whoa.

- S.

 

OH YOU'RE THE DADDY!

Post is coming along great now. Hopeful for the transparent stuff too, be really cool for particles etc...

 

man. . . . . just say it. . . . . .stop teasing. . .

 

you killing me. . . .

 

Any ideas why we are having problems with forward-only materials and AO , SSR?


SSAO Pro + old Unity's ScreenSpaceAmbientOcclusion works here without problems. Only way we can get this working is to turn on "ambient only" in AO, but it dont look as good as without it.

SSR (screenshot with debug mode "incoming radiance", you can clearly see that SSR kind of skips those models)

 

Sorry if this has already been answered, but how do I turn on or off the individual components in the Tonemapping in C#? For instance, turning on or off the 'Eye Adaptation' or 'Color Grading' checkboxes. I can see a '.enabled' property on the component but it seems to be read only?

 

Thanks Tim!

 

One problem is that those are Alloy shaders - are this attachment will be available for all or only for you?
I just checked build in shaders, and same thing is happening with Unlit/Texture (only in Deferred)



I did create issue in bitbucket so we can continue there.

 

Oh btw tim, can you still add this as an option for SSR, to use fake transparency with opaque?

 

@Tim C
In response to @reddotgames problem, what really needs to happen here is that these effects must use command buffers to directly apply to the G-Buffer's Light Accumulation Buffer before the forward materials are rendered. First, you would calculate SSRR and add it to the LAB. Then you would calculate SSAO and multiply it into the LAB. The only problem is that it wouldn't work for LDR mode, since that uses multiplicative blending for accumulating lights.

 

hope that here will be link for this ))

 

is everyone getting spammed by Histrogram error?
i'm getting it in 5.4 beta 14

Code (csharp):

1.  
2. Kernel 'KHistogramGather' not found
3. UnityEngine.ComputeShader:FindKernel(String)
4. UnityStandardAssets.CinematicEffects.TonemappingColorGradingEditor:UpdateHistogram(RenderTexture, Rect, HistogramMode) (at Assets/Standard Assets/Effects/CinematicEffects(BETA)/TonemappingColorGrading/Editor/TonemappingColorGradingEditor.cs:468)
5. UnityStandardAssets.CinematicEffects.TonemappingColorGradingEditor:OnFrameEnd(RenderTexture) (at Assets/Standard Assets/Effects/CinematicEffects(BETA)/TonemappingColorGrading/Editor/TonemappingColorGradingEditor.cs:449)
6. UnityStandardAssets.CinematicEffects.TonemappingColorGrading:OnRenderImage(RenderTexture, RenderTexture) (at Assets/Standard Assets/Effects/CinematicEffects(BETA)/TonemappingColorGrading/TonemappingColorGrading.cs:1009)
7.  
8. UnityException: FindKernel failed
9. UnityStandardAssets.CinematicEffects.TonemappingColorGradingEditor.UpdateHistogram (UnityEngine.RenderTexture source, Rect rect, HistogramMode mode) (at Assets/Standard Assets/Effects/CinematicEffects(BETA)/TonemappingColorGrading/Editor/TonemappingColorGradingEditor.cs:468)
10. UnityStandardAssets.CinematicEffects.TonemappingColorGradingEditor.OnFrameEnd (UnityEngine.RenderTexture source) (at Assets/Standard Assets/Effects/CinematicEffects(BETA)/TonemappingColorGrading/Editor/TonemappingColorGradingEditor.cs:449)
11. UnityStandardAssets.CinematicEffects.TonemappingColorGrading.OnRenderImage (UnityEngine.RenderTexture source, UnityEngine.RenderTexture destination) (at Assets/Standard Assets/Effects/CinematicEffects(BETA)/TonemappingColorGrading/TonemappingColorGrading.cs:1009)
12.  

 

I´ve got wrong results with Cinematic DepthOfField and old tree shaders (SoftOcclusionLeaves and SoftOcclusionBark):



Will this be fixed?

 

That needs to be fixed in the tree shader I think. Unless it can be made to write to the depth buffer I don't think it's possible to fix that.

 

OK - however - a fix would be nice since a lot of users use the old tree system (due to the uncomplete Speedtree integration).

 

Thanks! Already tested changing IsGbufferAvailable to false and AO is working great now! Cant wait for SSR fix.